huaxingao commented on a change in pull request #29396:
URL: https://github.com/apache/spark/pull/29396#discussion_r468266332



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTable.scala
##########
@@ -34,4 +38,16 @@ case class JDBCTable(ident: Identifier, schema: StructType, 
jdbcOptions: JDBCOpt
     capabilities.add(BATCH_READ)

Review comment:
       Will add `BATCH_WRITE`. Are these all we need to do to support 
`BATCH_READ` and `BATCH_WRITE`? I know you are working on `BATCH_READ`, but I 
thought there are more to do than just adding `BATCH_READ` capabilities. Sorry 
if you already have coded all these. @MaxGekk 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to