maropu commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-671681394
The proposed approach looks good to me. Some nit comments; > HashedRelation.getWithIndex(key: InternalRow): Iterator[(InternalRow, Int, Int)] If we use `HashSet[Long]` or `LongToUnsafeRowMap`, the returned type is `Iterator[(InternalRow, Long)]`? > and for LongHashedRelation, this method getWithIndex will leave with UnsupportedOperationException for now. Any plan to support the case? If we do so, the first key index should be long. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
