LuciferYang commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-672558251
The main change of Address [db90b1a](https://github.com/apache/spark/pull/29370/commits/db90b1acc87d709ca7643a258eccc31a2ff219ca) as follow: - Call `toSeq` in `AstBuilder#visitFunctionCall`, otherwise `ctx.argument.asScala.map(expression)` is `Buffer` in Scala 2.13 The effect as follow: - Pass `ExpressionParserSuite ` **Before** ``` Tests: succeeded 4035, failed 21, canceled 0, ignored 6, pending 0 *** 1 SUITE ABORTED *** *** 21 TESTS FAILED *** ``` **After** ``` Tests: succeeded 4035, failed 20, canceled 0, ignored 6, pending 0 *** 1 SUITE ABORTED *** *** 20 TESTS FAILED *** ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
