Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-88006325
@jerryshao, since you added unit tests for `localProperty` inheritance in
ffa5f8e, do you know of any actual use-cases that motivate this inheritance?
As far as I can tell, we don't seem to rely on it internally inside of Spark
and it's not documented in a user-facing way. Users can't be relying on it for
job group cancellation, since this patch demonstrates that this has always been
broken, and it seems unlikely that anyone would choose to use this for
cross-thread communication: in order to read and write these properties, you
need to have a reference to the SparkContext instance, at which point you might
as well just pass the information directly instead of implicitly inheriting it
across threads.
If there's no actual use for this inheritance, it might be nice to remove
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
