c21 commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-672644707
> I have a crazy idea: we can make the value length negative to indicate it's matched. Then the "matched bit" takes no extra memory. But I'm not sure how hard it is to update BytesToByteMap to support this hack. @cloud-fan - this is indeed crazy :). Honestly I feel it's becoming quite hacky where `BytesToBytesMap` is claimed to be `An append-only hash map` and we will break it with that. I will check tomorrow for feasibility but I feel either paths for now is fine for a starter new feature. Do you wanna take a look of current one that I have changed? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
