cloud-fan commented on a change in pull request #29423:
URL: https://github.com/apache/spark/pull/29423#discussion_r469719481
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -1273,3 +1275,24 @@ private[hive] object HiveClientImpl extends Logging {
hiveConf
}
}
+
+class HiveVoidType extends DataType {
+ override def defaultSize: Int = 1
+ override def asNullable: HiveVoidType = this
+ override def simpleString: String = "void"
+}
+
+case object HiveVoidType extends HiveVoidType {
Review comment:
can we use one single object instead of one class + one object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
