Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4708#issuecomment-88065322
LGTM, given the preceding reviews and passed tests. I can merge after just
giving @andrewor14 a short while more to chime in following his last comments.
The micro-improvements in the code style are good. The general stance is to
not bother unless the code is already being changed for other purposes. Here
some code is being changed that's not exactly already being edited as part of
this change. But it does contribute to the readability and that is the point of
this PR, and I doubt it will need to be back-ported, so the merge conflict
concern isn't really an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
