mundaym commented on a change in pull request #29407:
URL: https://github.com/apache/spark/pull/29407#discussion_r469928734
##########
File path: core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala
##########
@@ -214,6 +216,10 @@ class SizeEstimatorSuite
}
test("class field blocks rounding on 64-bit VM without useCompressedOops") {
+ System.setProperty(TEST_USE_COMPRESSED_OOPS_KEY, "false")
Review comment:
I think we should probably be as explicit as possible about what each
test is doing. Let me add a follow up commit using a helper function and you
can see what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
