HyukjinKwon commented on a change in pull request #29444:
URL: https://github.com/apache/spark/pull/29444#discussion_r471249424
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
##########
@@ -187,7 +187,7 @@ class TextSocketStreamSuite extends StreamTest with
SharedSparkSession {
test("non-boolean includeTimestamp") {
val provider = new TextSocketSourceProvider
- val params = Map("host" -> "localhost", "port" -> "1234",
"includeTimestamp" -> "fasle")
+ val params = Map("host" -> "localhost", "port" -> "1234",
"includeTimestamp" -> "false")
Review comment:
Seems like it was testing a negative case. `fasle` seems right value to
test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
