cloud-fan commented on a change in pull request #29224:
URL: https://github.com/apache/spark/pull/29224#discussion_r471346710
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala
##########
@@ -73,7 +74,8 @@ private[sql] class SessionState(
resourceLoaderBuilder: () => SessionResourceLoader,
createQueryExecution: LogicalPlan => QueryExecution,
createClone: (SparkSession, SessionState) => SessionState,
- val columnarRules: Seq[ColumnarRule]) {
+ val columnarRules: Seq[ColumnarRule],
+ val queryStagePrepRules: Seq[Rule[SparkPlan]]) {
Review comment:
Maybe I missed something. The session state builder is used to build
`SessionState`. `SparkSession` or `QueryExecition` doesn't hold session state
builder instance anymore.
Are you suggesting we create something like `Analyzer`, `Optimizer`, etc. to
wrap the post-planning rules in `QueryExecution`, so that we just pass that
wrapper around?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
