agrawaldevesh opened a new pull request #29452:
URL: https://github.com/apache/spark/pull/29452


   ### What changes were proposed in this pull request?
   The decommissioning state is a bit fragment across two places in the 
TaskSchedulerImpl:
   
   https://github.com/apache/spark/pull/29014/ stored the incoming decommission 
info messages in TaskSchedulerImpl.executorsPendingDecommission.
   While https://github.com/apache/spark/pull/28619/ was storing just the 
executor end time in the map TaskSetManager.tidToExecutorKillTimeMapping (which 
in turn is contained in TaskSchedulerImpl).
   While the two states are not really overlapping, it's a bit of a code 
hygiene concern to save this state in two places. 
   
   With https://github.com/apache/spark/pull/29422, TaskSchedulerImpl is 
emerging as the place where all decommissioning book keeping is kept within the 
driver. So consolidate the information in _tidToExecutorKillTimeMapping_ into 
_executorsPendingDecommission_. 
   
   However, in order to do so, we need to walk away from keeping the raw 
ExecutorDecommissionInfo messages and instead keep another class 
ExecutorDecommissionState. This decoupling will allow the RPC message class 
ExecutorDecommissionInfo to evolve independently from the book keeping 
ExecutorDecommissionState.
   
   
   ### Why are the changes needed?
   
   This is just a code cleanup. These two features were added independently and 
its time to consolidate their state for good hygiene.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Existing tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to