HeartSaVioR commented on a change in pull request #29256: URL: https://github.com/apache/spark/pull/29256#discussion_r471960294
########## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala ########## @@ -1106,6 +1107,54 @@ class StreamingQuerySuite extends StreamTest with BeforeAndAfter with Logging wi } } + test("union in streaming query of append mode without watermark") { + val inputData1 = MemoryStream[Int] + val inputData2 = MemoryStream[Int] + withTempView("s1", "s2") { + inputData1.toDF().createOrReplaceTempView("s1") + inputData2.toDF().createOrReplaceTempView("s2") + val unioned = spark.sql( + "select s1.value from s1 union select s2.value from s2") + checkExceptionMessage(unioned) + } + } + + test("distinct in streaming query of append mode without watermark") { + val inputData = MemoryStream[Int] + withTempView("deduptest") { + inputData.toDF().toDF("value").createOrReplaceTempView("deduptest") + val distinct = spark.sql("select distinct value from deduptest") + checkExceptionMessage(distinct) + } + } + + test("distinct in streaming query of complete mode") { + val inputData = MemoryStream[Int] + withTempView("deduptest") { + inputData.toDF().toDF("value").createOrReplaceTempView("deduptest") + val distinct = spark.sql("select distinct value from deduptest") + + testStream(distinct, Complete)( + AddData(inputData, 1, 2, 3, 3, 4), + CheckAnswer(Row(1), Row(2), Row(3), Row(4)) Review comment: As an alternative I added some note on SS guide doc. #29461 I'm not sure it is enough to let us free to not complained by improper usages, so I just marked the PR as draft. I think it's better to collect the voices on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org