cchighman commented on a change in pull request #28841: URL: https://github.com/apache/spark/pull/28841#discussion_r472586599
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala ########## @@ -0,0 +1,501 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources + +import java.io.File +import java.time.{LocalDateTime, ZoneOffset} +import java.time.format.DateTimeFormatter + +import org.apache.hadoop.fs.Path + +import org.apache.spark.sql.{AnalysisException, QueryTest, Row} +import org.apache.spark.sql.catalyst.util.{stringToFile, CaseInsensitiveMap, DateTimeUtils} +import org.apache.spark.sql.test.SharedSparkSession + +class PathFilterSuite extends QueryTest with SharedSparkSession { + import testImplicits._ + + test("SPARK-31962: when modifiedAfter specified with a past date") { + withTempDir { dir => + val path = new Path(dir.getCanonicalPath) + val file = new File(dir, "file1.csv") + stringToFile(file, "text") + file.setLastModified(DateTimeUtils.currentTimestamp()) + val df = spark.read + .option("modifiedAfter", "2019-05-10T01:11:00") + .format("csv") + .load(path.toString) + assert(df.count() == 1) + } + } + + test("SPARK-31962: when modifiedBefore specified with a future date") { + withTempDir { dir => + val path = new Path(dir.getCanonicalPath) + val file = new File(dir, "file1.csv") + stringToFile(file, "text") + val df = spark.read + .option("modifiedBefore", "2090-05-10T01:11:00") + .format("csv") + .load(path.toString) + assert(df.count() == 1) + } + } + + test("SPARK-31962: when modifiedBefore specified with a past date") { + withTempDir { dir => + val path = new Path(dir.getCanonicalPath) + val file = new File(dir, "file1.csv") + stringToFile(file, "text") + file.setLastModified(DateTimeUtils.currentTimestamp()) + val msg = intercept[AnalysisException] { + spark.read + .option("modifiedBefore", "1984-05-01T01:00:00") + .format("csv") + .load(path.toString) + }.getMessage + assert(msg.contains("Unable to infer schema for CSV")) + } + } + + test("SPARK-31962: when modifiedAfter specified with a past date, multiple files, one valid") { + withTempDir { dir => + val path = new Path(dir.getCanonicalPath) + val file1 = new File(dir, "file1.csv") + val file2 = new File(dir, "file2.csv") + stringToFile(file1, "text") + stringToFile(file2, "text") + file1.setLastModified(DateTimeUtils.currentTimestamp()) Review comment: So, looking for addition of one test which should expect a false outcome when timestamps are completely the same since we have not passed that respective time at that particular moment? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
