cloud-fan commented on a change in pull request #29455:
URL: https://github.com/apache/spark/pull/29455#discussion_r472731516
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -83,15 +83,18 @@ trait ShuffleExchangeLike extends Exchange {
case class ShuffleExchangeExec(
override val outputPartitioning: Partitioning,
child: SparkPlan,
- noUserSpecifiedNumPartition: Boolean = true) extends ShuffleExchangeLike {
+ noUserSpecifiedNumPartition: Boolean = true,
+ isNullAwareAntiJoin: Boolean = false) extends ShuffleExchangeLike {
Review comment:
This is too hacky, we shouldn't pollute the general shuffle node for one
specific case.
I think we need to develop a flexible stats collection framework for AQE
first. NAAJ is just one use case: it asks AQE to collect null count.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
