viirya commented on a change in pull request #29482:
URL: https://github.com/apache/spark/pull/29482#discussion_r473626391
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala
##########
@@ -241,7 +241,6 @@ class CountVectorizer @Since("1.5.0") (@Since("1.5.0")
override val uid: String)
}
wordCounts.unpersist()
- require(vocab.length > 0, "The vocabulary size should be > 0. Lower minDF
as necessary.")
Review comment:
Maybe it is also good to log something about the generated `vocab` is
empty? This `require` isn't only a prohibition but also warns that `minDF` is
set too high.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
