cloud-fan commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r473655110
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
##########
@@ -224,15 +224,15 @@ class DataFrameReaderWriterSuite extends QueryTest with
SharedSparkSession with
assert(LastOptions.parameters("opt3") == "3")
}
- test("SPARK-32364: path argument of load function should override all
existing options") {
+ test("SPARK-32364: later option should override earlier options") {
spark.read
.format("org.apache.spark.sql.test")
.option("paTh", "1")
.option("PATH", "2")
.option("Path", "3")
.option("patH", "4")
- .load("5")
Review comment:
can we add `.option("path", "5")` to keep the test unchanged?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
##########
@@ -224,15 +224,15 @@ class DataFrameReaderWriterSuite extends QueryTest with
SharedSparkSession with
assert(LastOptions.parameters("opt3") == "3")
}
- test("SPARK-32364: path argument of load function should override all
existing options") {
+ test("SPARK-32364: later option should override earlier options") {
spark.read
.format("org.apache.spark.sql.test")
.option("paTh", "1")
.option("PATH", "2")
.option("Path", "3")
.option("patH", "4")
- .load("5")
Review comment:
can we add `.option("path", "5")` to keep the test result unchanged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
