cloud-fan commented on a change in pull request #29484:
URL: https://github.com/apache/spark/pull/29484#discussion_r473675585
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -442,7 +446,11 @@ trait HashJoin extends BaseJoinExec with CodegenSupport {
case BuildRight => input ++ buildVars
}
- if (keyIsUnique) {
+ if (isEmptyHashedRelation) {
+ s"""
+ |// If HashedRelation is empty, hash inner join simply returns
nothing.
Review comment:
This isn't a short-cut and we still need to consume the entire stream
side. We need something similar to https://github.com/apache/spark/pull/29389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
