cloud-fan commented on a change in pull request #29476:
URL: https://github.com/apache/spark/pull/29476#discussion_r473818852
##########
File path: project/SparkBuild.scala
##########
@@ -852,6 +852,7 @@ object Unidoc {
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/spark/sql/hive/test")))
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/spark/sql/catalog/v2/utils")))
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/hive")))
+
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/spark/sql/v2/avro")))
Review comment:
I think the problem here is we have public APIs in the avro module,
while we assume it should all be private like other external modules.
I think a safer way is to use whitelist and only generate doc for the
classes we explicitly specified in avro module. Is it possible to do so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
