srowen commented on a change in pull request #29491:
URL: https://github.com/apache/spark/pull/29491#discussion_r474080884
##########
File path: dev/requirements.txt
##########
@@ -4,3 +4,5 @@ PyGithub==1.26.0
Unidecode==0.04.19
sphinx
pydata_sphinx_theme
+ipython
Review comment:
Are there other implications to this, like, our python packaging now
requires ipython when installing pyspark? (sorry ignorant question)
##########
File path: apt.txt
##########
@@ -0,0 +1 @@
+openjdk-8-jre
Review comment:
Is it possible to avoid putting this at the top level of the project? I
tried to stuff everything into dev/ as possible.
##########
File path: postBuild
##########
@@ -0,0 +1,21 @@
+#!/bin/bash
Review comment:
DItto putting this at the top level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
