viirya commented on a change in pull request #29457:
URL: https://github.com/apache/spark/pull/29457#discussion_r474164292
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -186,6 +183,15 @@ class OrcFileFormat
if (resultedColPruneInfo.isEmpty) {
Iterator.empty
} else {
+ // ORC predicate pushdown
+ if (orcFilterPushDown) {
+ OrcUtils.readCatalystSchema(filePath, conf, ignoreCorruptFiles).map
{ fileSchema =>
+ OrcFilters.createFilter(fileSchema, filters).foreach { f =>
Review comment:
Our ORC pushdown code, e.g., `buildLeafSearchArgument`, uses catalyst
schema in many places. I think it is still possible to use ORC's schema there
and remove catalyst schema, but it looks like a big change. If we want to do
it, I'd suggest to do it in another PR. This diff is already not small now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
