beliefer commented on a change in pull request #29228:
URL: https://github.com/apache/spark/pull/29228#discussion_r474393092
##########
File path: core/src/test/scala/org/apache/spark/LocalSparkContext.scala
##########
@@ -22,12 +22,39 @@ import org.scalatest.BeforeAndAfterAll
import org.scalatest.BeforeAndAfterEach
import org.scalatest.Suite
+import org.apache.spark.internal.Logging
import org.apache.spark.resource.ResourceProfile
/** Manages a local `sc` `SparkContext` variable, correctly stopping it after
each test. */
-trait LocalSparkContext extends BeforeAndAfterEach with BeforeAndAfterAll {
self: Suite =>
+trait LocalSparkContext extends BeforeAndAfterEach
+ with BeforeAndAfterAll with Logging{ self: Suite =>
+
+ private var _conf: SparkConf = defaultSparkConf
@transient var sc: SparkContext = _
+ @transient private var _sc: SparkContext = _
+
+ def getSparkConf: SparkConf = _conf
Review comment:
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala:49:
overriding method sparkConf in trait LocalSparkContext of type =>
org.apache.spark.SparkConf;
[error] variable sparkConf has weaker access privileges; it should not be
private
[error] private var sparkConf: SparkConf = _
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
