Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/482#discussion_r12038876
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -91,10 +91,53 @@ object ColumnPruning extends Rule[LogicalPlan] {
*/
object ConstantFolding extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- case q: LogicalPlan => q transformExpressionsDown {
+ case q: LogicalPlan => q transformExpressionsUp {
--- End diff --
`expression.foldable` is ok by traveling from top to bottom, while null
propagation is opposite. I've put them into different rule objects
(ConstantFolding & NullPropagation).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
