Fokko commented on a change in pull request #29491:
URL: https://github.com/apache/spark/pull/29491#discussion_r475073344
##########
File path: dev/requirements.txt
##########
@@ -4,3 +4,5 @@ PyGithub==1.26.0
Unidecode==0.04.19
sphinx
pydata_sphinx_theme
+ipython
Review comment:
The packages that are being installed, when installing pyspark are
defined in the setup.py:
https://github.com/apache/spark/blob/master/python/setup.py#L206
The defacto way is to add an `extras_require` called `dev` where you add the
development requirements. Preferably with a version attached to it, so you know
that Jenkins and the local dev environments are the same.
Happy to migrate this to the setup.py if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
