dongjoon-hyun commented on a change in pull request #29387:
URL: https://github.com/apache/spark/pull/29387#discussion_r475104752
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -3101,6 +3101,28 @@ abstract class DDLSuite extends QueryTest with
SQLTestUtils {
assert(spark.sessionState.catalog.isRegisteredFunction(rand))
}
}
+
+ test("Move data to trash on truncate table if enabled") {
+ withTable("tab1") {
+ withSQLConf(SQLConf.TRUNCATE_TRASH_ENABLED.key -> "true") {
Review comment:
@Udbhav30 . It's always good to have complete test coverage for your
patch. Please add negative test cases.
1. When `spark.sql.truncate.trash.enabled` is `false`, this should be no-op.
2. When `fs.trash.interval=-1`, this should be no-op.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
