gatorsmile commented on a change in pull request #29387:
URL: https://github.com/apache/spark/pull/29387#discussion_r475121069
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -3101,6 +3101,28 @@ abstract class DDLSuite extends QueryTest with
SQLTestUtils {
assert(spark.sessionState.catalog.isRegisteredFunction(rand))
}
}
+
+ test("Move data to trash on truncate table if enabled") {
+ withTable("tab1") {
+ withSQLConf(SQLConf.TRUNCATE_TRASH_ENABLED.key -> "true") {
+ sql("CREATE TABLE tab1 (col INT) USING parquet")
+ sql("INSERT INTO tab1 SELECT 1")
+
+ val tablePath = new Path(spark.sessionState.catalog
+ .getTableMetadata(TableIdentifier("tab1")).storage.locationUri.get)
+ val hadoopConf = spark.sessionState.newHadoopConf()
+ val fs = tablePath.getFileSystem(hadoopConf)
+ // trash interval should be configured from hadoop side
+ hadoopConf.setInt("fs.trash.Interval", 5)
+
+ val trashRoot = fs.getTrashRoot(tablePath)
Review comment:
All the FS support this operation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
