maropu commented on a change in pull request #29526:
URL: https://github.com/apache/spark/pull/29526#discussion_r475283970
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -176,9 +176,10 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
l.resolve(fsRelation.dataSchema,
fsRelation.sparkSession.sessionState.analyzer.resolver)
// Partition keys are not available in the statistics of the files.
+ val dataColumnsWithoutPartitionCols =
dataColumns.filterNot(partitionColumns.contains)
Review comment:
> It will possibly push down a predicate with partition column to
datasource.
Oh, I see. nit: could you leave some comments about "data columns `
dataColumns`can have partition columns... " above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
