dongjoon-hyun commented on a change in pull request #29477:
URL: https://github.com/apache/spark/pull/29477#discussion_r475289473
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -59,7 +59,8 @@ private[spark] class BasicExecutorFeatureStep(
.getOrElse(math.max(
(kubernetesConf.get(MEMORY_OVERHEAD_FACTOR) * executorMemoryMiB).toInt,
MEMORY_OVERHEAD_MIN_MIB))
- private val executorMemoryWithOverhead = executorMemoryMiB +
memoryOverheadMiB
+ private val memoryOffHeapMiB =
KubernetesUtils.executorOffHeapMemorySizeAsMb(kubernetesConf)
+ private val executorMemoryWithOverhead = executorMemoryMiB +
memoryOverheadMiB + memoryOffHeapMiB
Review comment:
Could you check the other resource manager (YARN/Mesos)? Do we request
like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
