AngersZhuuuu commented on a change in pull request #29526:
URL: https://github.com/apache/spark/pull/29526#discussion_r475310377
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -176,9 +176,10 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
l.resolve(fsRelation.dataSchema,
fsRelation.sparkSession.sessionState.analyzer.resolver)
// Partition keys are not available in the statistics of the files.
+ val dataColumnsWithoutPartitionCols =
dataColumns.filterNot(partitionColumns.contains)
Review comment:
> Sure. Added.
>
> It only happens in hive-1.2 profile, because for hive-2.3 we go for a
different path to create pushed down filters. In that path, we have checked if
an attribute is in the field map.
LGTM，when I doing that pr https://github.com/apache/spark/pull/29406, I
have thought that : from the code, seems dataColumns won't have partition col.
Thanks for these fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
