Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/5297#issuecomment-88580929
That is a good point, using monitorApplication actually waits for running
and that isn't necessarily what we want here. For instance it could be blocked
on running waiting on resources. So I apologize, what you had before is
better.
So a few comments on the old version.
- we don't need to do the sleep. We use the
YarnClientImpl.submitApplication which will handle that and even has a config
for configuring the poll interval.
- we should check the applicationReport you get to make sure the
application status isn't failed or killed. If they are failed or killed we
should make sure to throw so we exit with proper code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
