cloud-fan commented on a change in pull request #29475:
URL: https://github.com/apache/spark/pull/29475#discussion_r475695006
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -132,13 +132,13 @@ case class InSubqueryExec(
def updateResult(): Unit = {
val rows = plan.executeCollect()
result = child.dataType match {
- case _: StructType => rows.toArray
- case _ => rows.map(_.get(0, child.dataType))
+ case _: StructType => rows.toSet
Review comment:
This doesn't match the `InSet` implementation. For non-atomic type, we
need to build a `TreeSet` to recursively compare the elements of
struct/array/map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
