viirya commented on a change in pull request #29530:
URL: https://github.com/apache/spark/pull/29530#discussion_r476109029
##########
File path:
sql/core/v1.2/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -215,11 +215,11 @@ private[sql] object OrcFilters extends OrcFiltersBase {
* @return the builder so far.
*/
private def buildLeafSearchArgument(
- dataTypeMap: Map[String, DataType],
+ dataTypeMap: Map[String, OrcPrimitiveField],
expression: Filter,
builder: Builder): Option[Builder] = {
def getType(attribute: String): PredicateLeaf.Type =
- getPredicateLeafType(dataTypeMap(attribute))
+ getPredicateLeafType(dataTypeMap(attribute).fieldType)
Review comment:
yes.
##########
File path:
sql/core/v2.3/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -139,7 +139,7 @@ private[sql] object OrcFilters extends OrcFiltersBase {
/**
* Get PredicateLeafType which is corresponding to the given DataType.
*/
- private def getPredicateLeafType(dataType: DataType) = dataType match {
+ private[sql] def getPredicateLeafType(dataType: DataType) = dataType match {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
