beliefer commented on a change in pull request #28685:
URL: https://github.com/apache/spark/pull/28685#discussion_r476307341
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -352,17 +353,24 @@ abstract class OffsetWindowFunction
val default: Expression
/**
- * (Foldable) expression that contains the number of rows between the
current row and the row
- * where the input expression is evaluated.
+ * (Foldable) expression that contains the number of rows between the
current row or the first
+ * row of the entire window partition and the row where the input expression
is evaluated.
*/
val offset: Expression
/**
- * Direction of the number of rows between the current row and the row where
the input expression
- * is evaluated.
+ * Direction of the number of rows between the current row or the first row
of the entire
+ * window partition and the row where the input expression is evaluated.
*/
val direction: SortDirection
+ /**
+ * Whether the offset is start with the current row. If `isRelative` is
true, `offset` means
+ * the offset is start with the current row. otherwise, the offset is start
with the first
+ * row of the entire window partition.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
