cloud-fan commented on a change in pull request #29475:
URL: https://github.com/apache/spark/pull/29475#discussion_r476661739
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -114,9 +116,17 @@ case class InSubqueryExec(
child: Expression,
plan: BaseSubqueryExec,
exprId: ExprId,
- private var resultBroadcast: Broadcast[Array[Any]] = null) extends
ExecSubqueryExpression {
-
- @transient private var result: Array[Any] = _
+ private var resultBroadcast: Broadcast[Set[Any]] = null) extends
ExecSubqueryExpression {
+
+ @transient private var result: Set[Any] = _
+ @transient private lazy val hasNull: Boolean = result.contains(null)
Review comment:
shall we just keep an instance of `InSet` and call its `eval`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
