[GitHub] [spark] huaxingao commented on a change in pull request #29535: [SPARK-32592][SQL] Make DataFrameReader.table take the specified options

[GitBox]

huaxingao commented on a change in pull request #29535:
URL: https://github.com/apache/spark/pull/29535#discussion_r476942712



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -822,6 +821,8 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
    */
   def table(tableName: String): DataFrame = {
     assertNoSpecifiedSchema("table")
+    for ((k, v) <- this.extraOptions)
+      sparkSession.conf.set(k, v)

Review comment:
       @cloud-fan Thanks for your comment. 
   I took a look at the code. I think I need to change the following:
   
   <img width="896" alt="Screen Shot 2020-08-25 at 6 03 49 PM" 
src="https://user-images.githubusercontent.com/13592258/91242868-5aa37e80-e6fd-11ea-8498-2554d5c9367a.png";>
   
   
   <img width="900" alt="Screen Shot 2020-08-25 at 6 02 38 PM" 
src="https://user-images.githubusercontent.com/13592258/91242806-38116580-e6fd-11ea-8057-91ee3c3ef58e.png";>
   
   <img width="859" alt="Screen Shot 2020-08-25 at 6 02 50 PM" 
src="https://user-images.githubusercontent.com/13592258/91242813-3a73bf80-e6fd-11ea-9b67-5196f4597f73.png";>
   
   I need to modify lots of files because of the above changes. Could you 
please check if this looks OK to you before I continue? Thank you very much!
   
   
   
   
   
   
   
   
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org