Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5303#discussion_r27620676
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
 ---
    @@ -62,7 +75,10 @@ object IntegerLiteral {
       }
     }
     
    -case class Literal(value: Any, dataType: DataType) extends LeafExpression {
    +case class Literal (var value: Any, dataType: DataType) extends 
LeafExpression {
    --- End diff --
    
    I think you are right. Can we submit a separate PR to avoid using the 
constructor directly? Then we can merge this one.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to