yaooqinn commented on a change in pull request #29539:
URL: https://github.com/apache/spark/pull/29539#discussion_r477373353
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -333,4 +333,31 @@ class SparkMetadataOperationSuite extends
HiveThriftJdbcTest {
assert(pos === 17, "all columns should have been verified")
}
}
+
+ test("get columns operation should handle interval column properly") {
Review comment:
This PR fixes SparkGetColumnsOperation. As a meta operation, it is not
related to extract-queries that executed by SparkExecuteStatementOperation.
BTW, I notice that test cases for extracting interval values in VIEWS through
the thrift server might be missing in the current codebase. Maybe we can make
another PR to improve these, WDYT, @cloud-fan Or I can just add some UTs here
https://github.com/yaooqinn/spark/blob/d24d27f1bc39e915df23d65f8fda0d83e716b308/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala#L674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
