leanken commented on pull request #29547: URL: https://github.com/apache/spark/pull/29547#issuecomment-681291235
> Thanks @leanken for the fix. Just wondering is it possible to add a unit test for the issue? I considered adding a UT for this issue, too. But it's wrong usage about using scala object with Externalizable interface, since it is removed, I think scala case object itself can guarantee the serialization; besides, I've run the entire TPCDS just to make sure the E2E coverage, I think it should be enough, ^_^ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
