cloud-fan commented on a change in pull request #29539:
URL: https://github.com/apache/spark/pull/29539#discussion_r478234224
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -333,4 +333,31 @@ class SparkMetadataOperationSuite extends
HiveThriftJdbcTest {
assert(pos === 17, "all columns should have been verified")
}
}
+
+ test("get columns operation should handle interval column properly") {
+ val viewName = "view_interval"
+ val ddl = s"CREATE GLOBAL TEMP VIEW $viewName as select interval 1 day as
i"
+
+ withJdbcStatement(viewName) { statement =>
+ statement.execute(ddl)
+ val data = statement.getConnection.getMetaData
+ val rowSet = data.getColumns("", "global_temp", viewName, null)
+ while (rowSet.next()) {
+ assert(rowSet.getString("TABLE_CAT") === null)
+ assert(rowSet.getString("TABLE_SCHEM") === "global_temp")
+ assert(rowSet.getString("TABLE_NAME") === viewName)
+ assert(rowSet.getString("COLUMN_NAME") === "i")
+ assert(rowSet.getInt("DATA_TYPE") === java.sql.Types.OTHER)
+
assert(rowSet.getString("TYPE_NAME").equalsIgnoreCase(CalendarIntervalType.sql))
Review comment:
if we treat it as string type, can we still report the `TYPE_NAME` as
`INTERVAL`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
