Fokko commented on a change in pull request #29563:
URL: https://github.com/apache/spark/pull/29563#discussion_r478671291
##########
File path: python/pyspark/sql/tests/test_udf.py
##########
@@ -292,7 +292,6 @@ def test_udf_with_filter_function(self):
def test_udf_with_aggregate_function(self):
df = self.spark.createDataFrame([(1, "1"), (2, "2"), (1, "2"), (1,
"2")], ["key", "value"])
from pyspark.sql.functions import col, sum
- from pyspark.sql.types import BooleanType
Review comment:
Imported top level
##########
File path: python/pyspark/sql/tests/test_udf.py
##########
@@ -465,7 +464,6 @@ def test_udf_shouldnt_accept_noncallable_object(self):
def test_udf_with_decorator(self):
from pyspark.sql.functions import lit
- from pyspark.sql.types import IntegerType, DoubleType
Review comment:
Imported top level
##########
File path: python/pyspark/ml/fpm.py
##########
@@ -15,11 +15,13 @@
# limitations under the License.
#
-from pyspark import keyword_only
+import sys
Review comment:
This import was missing as well
##########
File path: python/pyspark/ml/pipeline.py
##########
@@ -14,11 +14,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+import os
Review comment:
Missing import
##########
File path: python/pyspark/sql/readwriter.py
##########
@@ -1225,7 +1226,6 @@ def overwrite(self, condition):
Overwrite rows matching the given filter condition with the contents
of the data frame in
the output table.
"""
- condition = _to_java_column(column)
Review comment:
It could not resolve `column`, this seems like a bug
##########
File path: python/pyspark/sql/tests/test_udf.py
##########
@@ -521,8 +519,6 @@ def as_double(x):
)
def test_udf_wrapper(self):
- from pyspark.sql.types import IntegerType
Review comment:
Imported top level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
