mingjialiu opened a new pull request #29564:
URL: https://github.com/apache/spark/pull/29564
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
A. Change the returned type of function pushedFilters from Seq[Expression]
to Seq[Filter].
1. DataSourceV2ScanExec
2. DataSourceV2Relation
3. StreamingDataSourceV2Relation
are the three classes that override pushedFilters from trait
4. DataSourceV2StringFormat
B. Change returned type of DataSourceV2Strategy.pushFilter the same way to
accommodate B.
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Query plan of DataSourceV2 fails to reuse any exchange. This change can make
DataSourceV2's plan more optimized and reuse exchange as DataSourceV1 and
parquet do.
More explanation. Why changing from Expression to Filter ?
- DataSourceV2ScanExec.pushedFilters are defined as array of Expressions
whose equal function has expression_id in scope. So for example, Expression
isnotnull(d_day_name#22364) is not considered equal to
isnotnull(d_day_name#22420). Therefore, the right thing is to define and
compare pushedFilter as Filter class.
- At both [Spark 3.0
](https://github.com/apache/spark/blob/2dee4352a0a3578818f1e364ee324fc012fbb91d/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala#L37)
and affected [Spark 2.4's tests
suite](https://github.com/apache/spark/blob/5b1b9b39eb612cbf9ec67efd4e364adafcff66c4/sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala#L450),
Filter is the class being used. And the above 4 places seem to be the only
places that miss to have pushedFilter as class Filter.
(Because pushedFilters are defined the right way in the above test suite,
[Spark 32708](https://issues.apache.org/jira/browse/SPARK-32708#) was not
caught by my
[tests](https://github.com/apache/spark/blob/5b1b9b39eb612cbf9ec67efd4e364adafcff66c4/sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala#L392)
previously added for
[SPARK-32609](https://issues.apache.org/jira/browse/SPARK-32609), another
exchange reuse bug.
- Usage of Expression was introduced by PR[ [SPARK-23203][SQL] DataSourceV2:
Use immutable logical
plan](https://github.com/apache/spark/commit/aadf9535b4a11b42fd9d72f636576d2da0766199).
From the PR's description and original intention, I don't see a necessary
reason to maintain Expression.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
passed existing tests of core, sql and catalyst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
