maropu commented on a change in pull request #29566:
URL: https://github.com/apache/spark/pull/29566#discussion_r478785918
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsTestUtils.scala
##########
@@ -254,6 +254,24 @@ trait SQLMetricsTestUtils extends SQLTestUtils {
}
}
}
+
+ /**
+ * Verify if the metrics in `SparkPlan` operator are same as expected
metrics.
+ *
+ * @param plan `SparkPlan` operator to check metrics
+ * @param expectedMetrics the expected metrics. The format is `metric name
-> metric value`.
+ */
+ protected def testMetricsInSparkPlanOperator(
Review comment:
We need to put this func here instead of `SQLMetricsSuite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
