Fokko commented on a change in pull request #29563:
URL: https://github.com/apache/spark/pull/29563#discussion_r479066067



##########
File path: python/pyspark/sql/readwriter.py
##########
@@ -1225,7 +1226,6 @@ def overwrite(self, condition):
         Overwrite rows matching the given filter condition with the contents 
of the data frame in
         the output table.
         """
-        condition = _to_java_column(column)

Review comment:
       I think it is a copy/paste error:
   ```python
       @since(3.1)
       def overwrite(self, condition):
           """
           Overwrite rows matching the given filter condition with the contents 
of the data frame in
           the output table.
           """
           condition = _to_java_column(column)
           self._jwriter.overwrite(condition)
   ```
   Above is the original function, I don't know where the column could come 
from. cc @zero323 @HyukjinKwon 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to