yaooqinn opened a new pull request #29577:
URL: https://github.com/apache/spark/pull/29577


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   
   This PR adds extended information of a function including arguments, 
examples, notes and the since field to the SparkGetFunctionOperation
   
   
   
   
   
   ### Why are the changes needed?
   
   better user experience, it will help JDBC users to have a better 
understanding of our builtin functions
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   Yes, BI tools and JDBC users will get full information on a spark function 
instead of only fragmentary usage info.
   
   
   e.g. date_part
   
   
   #### before
   
   ```
   date_part(field, source) - Extracts a part of the date/timestamp or interval 
source.
   ```
   #### after
   
   ```
       Usage:
         date_part(field, source) - Extracts a part of the date/timestamp or 
interval source.
   
       Arguments:
         * field - selects which part of the source should be extracted, and 
supported string values are as same as the fields of the equivalent function 
`EXTRACT`.
         * source - a date/timestamp or interval column from where `field` 
should be extracted
     
       Examples:
         > SELECT date_part('YEAR', TIMESTAMP '2019-08-12 01:00:00.123456');
          2019
         > SELECT date_part('week', timestamp'2019-08-12 01:00:00.123456');
          33
         > SELECT date_part('doy', DATE'2019-08-12');
          224
         > SELECT date_part('SECONDS', timestamp'2019-10-01 00:00:01.000001');
          1.000001
         > SELECT date_part('days', interval 1 year 10 months 5 days);
          5
         > SELECT date_part('seconds', interval 5 hours 30 seconds 1 
milliseconds 1 microseconds);
          30.001001
     
       Note:
         The date_part function is equivalent to the SQL-standard function 
`EXTRACT(field FROM source)`
   
       Since: 3.0.0
   
   ```
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   
   New tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to