dongjoon-hyun commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r479690817
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java
##########
@@ -18,15 +18,32 @@
package org.apache.spark.network.shuffle;
import java.io.Closeable;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Arrays;
import java.util.Collections;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
import com.codahale.metrics.MetricSet;
+import org.apache.spark.network.client.RpcResponseCallback;
+import org.apache.spark.network.client.TransportClient;
+import org.apache.spark.network.client.TransportClientFactory;
+import org.apache.spark.network.shuffle.protocol.BlockTransferMessage;
+import org.apache.spark.network.shuffle.protocol.GetLocalDirsForExecutors;
+import org.apache.spark.network.shuffle.protocol.LocalDirsForExecutors;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
Review comment:
Hi, @Ngone51 . Could you follow the community guide for `import` order,
please?
-
https://github.com/databricks/scala-style-guide/blame/master/README.md#L403-L408
For Java code, Apache Spark follows Oracle’s Java code conventions and Scala
guidelines below. The latter is preferred. And, Apache Spark follows the
official Scala style guide and Databricks Scala guide. The latter is preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
