dongjoon-hyun commented on a change in pull request #29552:
URL: https://github.com/apache/spark/pull/29552#discussion_r479699075
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -269,6 +269,29 @@ private[spark] object Utils extends Logging {
file.setExecutable(true, true)
}
+ /**
+ * Move data to trash if 'spark.sql.truncate.trash.enabled' is true, else
+ * delete the data permanently. If move data to trash failed fallback to
hard deletion.
+ */
+ def moveToTrashOrDelete(
+ fs: FileSystem,
+ partitionPath: Path,
+ isTrashEnabled: Boolean,
+ hadoopConf: Configuration): Boolean = {
+ if (isTrashEnabled) {
+ logDebug(s"will move data ${partitionPath.toString} to trash")
Review comment:
`will move` -> `Try to move`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
