dbtsai commented on a change in pull request #29567:
URL: https://github.com/apache/spark/pull/29567#discussion_r479734534
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
##########
@@ -165,4 +165,23 @@ class SimplifyConditionalSuite extends PlanTest with
PredicateHelper {
Literal(1))
)
}
+
+ test("simplify if when then clause is null and else clause is boolean") {
+ val p = IsNull('a)
+ val nullLiteral = Literal(null, BooleanType)
+ assertEquivalent(If(p, nullLiteral, FalseLiteral), And(p, nullLiteral))
+ assertEquivalent(If(p, nullLiteral, TrueLiteral), Or(IsNotNull('a),
nullLiteral))
+
+ // the rule should not apply to nullable predicate
+ Seq(TrueLiteral, FalseLiteral).foreach { b =>
+ assertEquivalent(If(GreaterThan('a, 42), nullLiteral, b),
+ If(GreaterThan('a, 42), nullLiteral, b))
+ }
+
+ // check evaluation also
+ Seq(TrueLiteral, FalseLiteral).foreach { p =>
Review comment:
should we use the same name in the foreach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
