sunchao commented on a change in pull request #29567:
URL: https://github.com/apache/spark/pull/29567#discussion_r479833572
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -463,6 +463,8 @@ object SimplifyConditionals extends Rule[LogicalPlan] with
PredicateHelper {
case If(Literal(null, _), _, falseValue) => falseValue
case If(cond, trueValue, falseValue)
if cond.deterministic && trueValue.semanticEquals(falseValue) =>
trueValue
+ case If(cond, l @ Literal(null, _), FalseLiteral) if !cond.nullable =>
And(cond, l)
+ case If(cond, l @ Literal(null, _), TrueLiteral) if !cond.nullable =>
Or(Not(cond), l)
Review comment:
For a Spark `Expression`, deterministic means that for fixed input it
should always return the same result (e.g., a deterministic function), while
`nullable` means whether it will be evaluated to null. In this case we need the
latter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
