ulysses-you commented on a change in pull request #29586:
URL: https://github.com/apache/spark/pull/29586#discussion_r479851165
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -256,7 +256,10 @@ case class UnresolvedFunction(
override lazy val resolved = false
override def prettyName: String = name.unquotedString
- override def toString: String = s"'$name(${children.mkString(", ")})"
+ override def toString: String = {
+ val distinct = if (isDistinct) "distinct " else ""
+ s"'$name($distinct${children.mkString(", ")})"
Review comment:
Seems we can check none in `Expression.flatArguments` to avoid these
case.
```
protected def flatArguments: Iterator[Any] = stringArgs.flatMap {
case t: Iterable[_] => t
case single => single :: Nil
case None => Nil
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
