AngersZhuuuu commented on a change in pull request #28490:
URL: https://github.com/apache/spark/pull/28490#discussion_r479942446
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3496,6 +3496,98 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
checkIfSeedExistsInExplain(df2)
}
+ test("SPARK-31670: Resolve Struct Field in Grouping Aggregate with same
ExprId") {
+ withTempView("t") {
+ sql(
+ """
+ |CREATE TEMPORARY VIEW t(a, b, c) AS
+ |SELECT * FROM VALUES
+ |('A', 1, NAMED_STRUCT('row_id', 1, 'json_string', '{"i": 1}')),
+ |('A', 2, NAMED_STRUCT('row_id', 2, 'json_string', '{"i": 1}')),
+ |('A', 2, NAMED_STRUCT('row_id', 2, 'json_string', '{"i": 2}')),
+ |('B', 1, NAMED_STRUCT('row_id', 3, 'json_string', '{"i": 1}')),
+ |('C', 3, NAMED_STRUCT('row_id', 4, 'json_string', '{"i": 1}'))
+ """.stripMargin)
+
+ checkAnswer(
+ sql(
+ """
+ |SELECT a, c.json_string, SUM(b)
+ |FROM t
+ |GROUP BY a, c.json_string
+ |WITH CUBE
Review comment:
> does normal GROUP BY have this bug?
No, this happened when construct group Analytics, and changed code only fix
this too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
