wzhfy commented on pull request #29594: URL: https://github.com/apache/spark/pull/29594#issuecomment-684135713
> ~The refactoring looks okay. I have only one question on the decision, [#29594 (comment)](https://github.com/apache/spark/pull/29594#discussion_r480324425).~ > > Never mind. The name `assertEqualPlans` was misleading to me, but now I see that it's technically `assertEqualJoinPlan`. @dongjoon-hyun I think `assertEqualJoinPlan` is a better name, thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
